Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ws early data compatibility #585

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

hzdrro
Copy link
Contributor

@hzdrro hzdrro commented May 14, 2023

f53d0ab 之后,如果early_data_header_name没有被用户设置,将会被设置成xray默认的Sec-WebSocket-Protocol(实际上前面已经判断过xray的情况了),但这不是v2ray或sing-box的默认行为

@ghost
Copy link

ghost commented May 14, 2023

鉴于大部分用户的能力,建议改成输入某个参数就为空,而不是使用 Sec-Websocket-Protocol

@arm64v8a
Copy link
Contributor

请问这两个 core 不填 header name ,单独填写 earlydata length 时的行为是怎样的?

@hzdrro
Copy link
Contributor Author

hzdrro commented May 14, 2023

请问这两个 core 不填 header name ,单独填写 earlydata length 时的行为是怎样的?

两者默认都是在路径中发送,不使用header
https://www.v2fly.org/v5/config/stream/websocket.html
https://sing-box.sagernet.org/zh/configuration/shared/v2ray-transport/#websocket

@arm64v8a
Copy link
Contributor

感谢指出

@arm64v8a arm64v8a merged commit 9f21603 into MatsuriDayo:main May 15, 2023
@hzdrro hzdrro deleted the fix_ws_ed branch May 15, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants