This repository has been archived by the owner on Jan 29, 2019. It is now read-only.
Fix: remove build step that copies dependent frameworks for HarvestKit #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version when used with Carthage causes duplicate frameworks copied into the final app bundle. The PR removes copy frameworks build phase from the framework target.
See also issue: Carthage/Carthage#353
"
jspahrsummers commented on Feb 24, 2015
@ryanfitz That probably means there's a “Copy Frameworks” build phase for your framework target. That should generally be deleted. However, any applications using your framework will then need to link all of its dependencies.
This is generally what you want, though, because it reduces duplication if another dependency wants to link one of those nested frameworks too."