fix: Generate image tags properly

MattKobayashi · Sep 28, 2024 · a0c8d6a · a0c8d6a
1 parent e245a4f
commit a0c8d6a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/build-publish.yml b/.github/workflows/build-publish.yml
@@ -5,11 +5,6 @@ on:
   release:
     types:
       - published
-  push:
-    branches:
-      - main
-    tags:
-      - 'v[0-9]+*'
   workflow_dispatch:
 
 env:
@@ -129,6 +124,10 @@ jobs:
         uses: docker/metadata-action@v5.5.1
         with:
           images: ${{ env.REGISTRY }}/${{ needs.build-setup.outputs.repo-owner }}/${{ matrix.container }}
+          tags: |
+            type=semver,pattern=v{{version}},event=tag
+            type=semver,pattern=v{{major}}.{{minor}},event=tag
+            type=semver,pattern=v{{major}},event=tag
       # Build and push Docker image with Buildx (don't push on PR)
       # https://github.com/docker/build-push-action
       - name: Build and push Docker image

diff --git a/.github/workflows/release-please.yaml b/.github/workflows/release-please.yaml
@@ -22,6 +22,7 @@ jobs:
           # this is a built-in strategy in release-please, see "Action Inputs"
           # for more options
           release-type: simple
+          token: ${{ secrets.RP_TOKEN }}
       - uses: actions/checkout@v4.2.0
       - name: Tag major and minor versions
         if: ${{ steps.release.outputs.release_created }}