Some immediate fixes I needed #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleschri Apologies for delay! Suspect these are all fine to merge, and thanks, but one q - what was the reason to change target to .net 4.7.2? |
|
Connecting to TLS 1.2 on versions before 4.7.x was nasty to do as it did not take TLS preferences from the OS settings and had to explicitely be enabled in code. To support TLS 1.3 you even have to target 4.8.x+. See also: But you can revert that if you wish to, should not have side effects other than TLS behavior. |
|
Makes sense to me - many thanks for the explanation. I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not thoroughly tested but seems stable to me.