This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
fix: set event options as optional #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MatteoGabriele
approved these changes
Dec 13, 2019
|
🎉 This PR is included in version 5.19.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
As mentioned #258 (comment) by @johnjcamilleri the options in the types should be optional.
What is the current behavior? (You can also link to an open issue here)
Options for the
eventFnwas not optionalWhat is the new behavior (if this is a feature change)?
Options for the
eventFnis optionalDoes this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: