-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix draining of slots having a startd name #123
Conversation
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
=========================================
+ Coverage 97.68% 97.7% +0.01%
=========================================
Files 39 39
Lines 1424 1435 +11
=========================================
+ Hits 1391 1402 +11
Misses 33 33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good. I added one comment as I don't know if both Machine
and Name
should be given.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections. Good to see Tardis supports this now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it 👍
TARDIS
supports running more than oneDrone
on the same host. To differentiate the drones, the tardis-uuid has been introduced and will be set asSTARTD_NAME
on the corresponding sites. The HTCondorName
in this case isDue to backward compatibility for sites running only one
Drone
per host,TARDIS
supports also drones without having aSTARTD_NAME
. Leading toas HTCondor
Name
.Currently,
TARDIS
drains drones by using just its hostname (HTCondorMachine
)which does not work in case multiple drones running on the same host. This pull request fixes this bug by using the HTCondor
Name
instead.