Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyauditor to 0.5.0 #346

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

dirksammel
Copy link
Contributor

This PR updates pyauditor to v0.5.0

@giffels giffels requested review from a team, eileen-kuehn and mschnepf and removed request for a team April 25, 2024 09:38
@giffels giffels force-pushed the update-pyauditor-v0.5.0 branch from 4c62e2f to 2b7b7a5 Compare April 25, 2024 10:43
@giffels
Copy link
Member

giffels commented Apr 25, 2024

I have rebased it to the current master, to fix the issues with the unittests.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (39fc5cd) to head (2b7b7a5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          55       55           
  Lines        2226     2226           
=======================================
  Hits         2202     2202           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giffels giffels self-requested a review April 25, 2024 10:53
Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution. I will address the failed Flake8 check in a #347, since they are not related to that PR.

Copy link
Member

@mschnepf mschnepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me 😄

@giffels giffels added this pull request to the merge queue Apr 29, 2024
Merged via the queue into MatterMiners:master with commit 72b113e Apr 29, 2024
15 of 16 checks passed
@giffels giffels mentioned this pull request Apr 29, 2024
4 tasks
giffels added a commit to giffels/tardis that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants