-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs with interactive examples #136
Update docs with interactive examples #136
Conversation
@MatthewFlamm, one suggestion I have is to turn on edge visibility in the global theme for the docs here. I think it helps alot to show the cell edges and where the sampled points lie with respect to the cells and their resolution |
Thanks! This still isn't working for me, at least on a codespaces container, but maybe there is some additional port forwarding I need to do. I won't have a local machine for testing for awhile. I did: pip install -r requirements-doc.txt
cd doc
make html
make serve-html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 5 5
Lines 345 345
=======================================
Hits 342 342
Misses 3 3 ☔ View full report in Codecov by Sentry. |
I had tested that installing all the PyVista requirements for documentation worked. I tried uninstalling those and then added I can confirm that serving the html from codespaces works as expected. |
Some dependency, or dependencies, of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Coming back to this, I pushed the changes to GitHub Pages, so this is now live. It looks great. Thanks for your help on this again! I also switched over to using I had to revamp the examples to use glyphs for spheres as |
Thanks for pointing that out! I too have come back to this PR a few times to see how its done to repeat in work like bjlittle/geovista#632. We really ought to better document this in PyVista |
I think this is all that is needed to resolve #133 -- at least its working locally for me. I suspect we might need to add other dependencies though? Let's see if CI is happy
I also changed the API docs so that that the long function names weren't appearing in the navbar