Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssertionError #8

Closed
m-noonan opened this issue Jun 16, 2023 · 3 comments
Closed

AssertionError #8

m-noonan opened this issue Jun 16, 2023 · 3 comments

Comments

@m-noonan
Copy link

Hello, I'm running IsoTools in command line and keep getting an AssertionError with the TALAM1 gene after sample import. Is this something on my end? Does it have to do with the annotation I'm using? I previously ran IsoTools with just 2 mouse samples and it worked just fine, so I'm not sure if it's something to do with my human genome/reference and/or samples. Any help would be appreciated!

samples='samples.txt'
anno='gencode.v43.annotation.gtf'
genome='GRCh38.primary_assembly.genome.fa'

run_isotools
--anno $anno
--log INFO
--progress_bar
--genome $genome
--samples $samples
--file_prefix ./isotools
--group_by group
--diff
--diff_plots 5
--diff NT/KD

59%|███████████████████████████████████████████████████▋ | 142870/243415 [1:21:17<57:12, 29.29genes/s]2023-06-15 19:14:41 ERROR: Gene TALAM1 chr11:65499311-65507432(-), 1 reference transcripts, 150 expressed transcripts TSS= {'hNT1': {65504026: 1}}, PAS={'hNT1': {65500537: 1}} -> TSS_unified= {'hNT1': {65500848: 1}}, PAS_unified={'hNT1': {65500537: 1}}
59%|███████████████████████████████████████████████████▋ | 142884/243415 [1:21:17<57:11, 29.30genes/s]
Traceback (most recent call last):
File "/home/data/Megan/anaconda3/bin/run_isotools", line 8, in
sys.exit(main())
File "/home/data/Megan/anaconda3/lib/python3.9/site-packages/isotools/run_isotools.py", line 66, in main
isoseq = load_isoseq(args)
File "/home/data/Megan/anaconda3/lib/python3.9/site-packages/isotools/run_isotools.py", line 155, in load_isoseq
isoseq.add_qc_metrics(args.genome, progress_bar=args.progress_bar)
File "/home/data/Megan/anaconda3/lib/python3.9/site-packages/isotools/_transcriptome_filter.py", line 68, in add_qc_metrics
g._unify_ends()
File "/home/data/Megan/anaconda3/lib/python3.9/site-packages/isotools/gene.py", line 897, in _unify_ends
assert end > tr['exons'][-1][0] or len(tr['exons']) == 1, 'error unifying %s: %s<=%s' % (tr["exons"], end, tr['exons'][-1][0])
AssertionError: error unifying [[65500537, 65500920], [65501008, 65504026]]: 65500848<=65501008

@MatthiasLienhard
Copy link
Owner

Hi m-nooan,

thank you for reporting this bug. I made an attempt to fix it, can you please download the development branch from git, install it and then run your analysis again?

git clone -b development https://github.com/MatthiasLienhard/isotools.git
cd isotools
python3 -m pip install .

If this does not work, would you be willing to share a small part of your data to reconstruct the bug on my side? I guess the easiest would be to extract all reads overlapping this gene with samtools.

Best, Matthias

@MatthiasLienhard
Copy link
Owner

This should be fixed now, in 0.3.4. If something is not working, please file a new issue.

@m-noonan
Copy link
Author

Just wanted to come back and let you know I tried it with the update 0.3.4 and it worked! Thanks for the fix!

IceFreez3r added a commit to IceFreez3r/isotools that referenced this issue Oct 14, 2024
* Added types, variable renames, refactored functions

They improve code readability and auto completion in IDEs. I doubt that they are complete yet, some specifically marked as "Any" because I wasn't certain.
Renamed abbreviated variables. Increases code readability. Follow up to the previous commits.
Refactored `has_overlap` and `get_intersects` in _utils.py. Especially the later one was unnecessarily complex.

* version number

* Types, error handling, variable names, splice_bubbles tweaked

moved from numeric type ids in _find_splice_bubbles_at_position to readable strings
  TSS and PAS are broken for this one I think, left two TODO comments

* SQANTI support import, new filters, filtered coordination test

more types

* Changed TSS/PAS events from 1 vs All to 1 vs 1

* Fix gene track without annotation

* Fix swapped 3' and 5' fragment

* Typos, variable renames and removing unused code

* Quote type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants