python.gram column number fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxError expects 1-indexed column numbers, but tokens are 0-indexed. Fixes we-like-parsers#47
|
I completely missed this, sorry. I will try to pick this up again so I will merge and keep going. |
MatthieuDartiailh
added a commit
that referenced
this pull request
Apr 1, 2022
python.gram column number fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you suggested in this comment, here's a fix to we-like-parsers#41 that includes all the row/column tests, as well as a fix to we-like-parsers#47
P.S. If you'd rather I send this PR directly to
we-like-parsers, let me know.P.P.S. Congrats on getting Python 3.10 release together today!