fix(config): Update path handling logic to work on Windows #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The windows testing is behaving so strange. Locally everything works fine, I've tried both manual testing by running |
|
I see! Ok then, let's revert the changes to get the windows CI to work and then I'll merge :) |
|
maybe add a comment explaining the need for |
Pupix
force-pushed
the
fix/windows-relative-path
branch
from
2a71c22 to
7e1b24f
Compare
|
I've added the core changes in the comment. If I need to change it further let me know. |
Pull Request Test Coverage Report for Build 12805131977Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261