Create RxFingerprint instance via Builder instead of static methods #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to move RxFingerprint away from it's static methods in the
RxFingerprint
class to access all RxFingerprint functions. Instead this proposal adds anRxFingerprint.Builder
which would be used to create a concrete instance ofRxFingerprint
with all "constant" parameters defined per the instance. This results in easier and less duplicated methods for calling RxFingerprint encryption/decryption.On the current
master
branch RxFingerprint has 5 methods with different parameters for encryption. This approach would simplify this and bring it down to 2 methods. This would make calling RxFingerprint clearer and would ensure that constant parameters are not changed across different calls to RxFingerprint.Creating an RxFingerprint instance:
Encryption would then be simply calling:
Due to the breaking API changes this would result in a RxFingerprint v3.