Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Display system host name in the server widget #189

Closed
JesseWebDotCom opened this issue Jul 7, 2022 · 2 comments
Closed

[Feature] Display system host name in the server widget #189

JesseWebDotCom opened this issue Jul 7, 2022 · 2 comments

Comments

@JesseWebDotCom
Copy link

JesseWebDotCom commented Jul 7, 2022

Description of the feature

I'd like to be able to display the host machine name (with the "dash." removed). This allows people that do not have an FQDN or domain to have their system host name displayed. I imagine the configuration option would be like the below:

DASHDOT_SHOW_SYSTEM_HOST

If you want to show the system host name in the server widget (e.g. my_server).

  • type: boolean
  • default: false

Note that this will only be shown when DASHDOT_SHOW_HOST=false

Additional context

So for example, if I have a physical computer named "HAPPY" that runs docker and the dash container, DASHDOT_SHOW_SYSTEM_HOST=true would replace "dash." with "HAPPY"

@MauriceNino
Copy link
Owner

So, after some thinking about it, I decided that I will only implement the flag to change the page title. I see the name in the server widget as "branding" and removing that is not really something I want to do.

So in the next release there will be a new flag DASHDOT_PAGE_TITLE which can be set to any string value, that is then (after some loading delay) set as the page title.

MauriceNino added a commit that referenced this issue Jul 8, 2022
# [4.3.0](v4.2.0...v4.3.0) (2022-07-08)

### Features

* **view:** add option to set page title ([e42fb84](e42fb84)), closes [#189](#189)
@MauriceNino
Copy link
Owner

🎉 This issue has been resolved in version 4.3.0

Please check the changelog for more details.

alan-caio added a commit to alan-caio/healthcare-dshboard-react-node that referenced this issue Jul 28, 2022
# [4.3.0](MauriceNino/dashdot@v4.2.0...v4.3.0) (2022-07-08)

### Features

* **view:** add option to set page title ([e42fb84](MauriceNino/dashdot@e42fb84)), closes [#189](MauriceNino/dashdot#189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants