[pull] main from llvm:main #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
unevaluated context Closes #58133 The direct cause for this issue is that the compilation process continues after it found it is in a invalid state. [expr.await]p2 says clearly that the co_await expressions are not allowed to appear in unevaluated context. So we can exit early in this case. It also reduces many redundant diagnostic messages (Such as 'expression with side effects has no effect in an unevaluated context').
Differential Revision: https://reviews.llvm.org/D134952
Move common logic shared by callers of getConstraint that use the result to query the constraint system to a new helper getConstraintForSolving. This includes common legality checks (i.e. not an equality constraint, no new variables) and the logic to query the unsigned system if possible for signed predicates.
Differential Revision: https://reviews.llvm.org/D135510
Fixes clangd/clangd#170 This patch actually consists of 2 fixes: 1) Add handling for UsingShadowDecl to canonicalRenameDecl(). This fixes the issue described in clangd/clangd#170. 2) Avoid the "there are multiple symbols under the cursor error" by applying similar logic as in https://reviews.llvm.org/D133664. This also partly fixes clangd/clangd#586. Differential Revision: https://reviews.llvm.org/D135489
…ction definition Fixes: #58217 This change is to remove extraneous and unnecessary ';' from after a function definition, its off by default and carries the same "code modification" warning as some of our other code manipulating changes. Reviewed By: HazardyKnusperkeks, owenpan Differential Revision: https://reviews.llvm.org/D135466
Reviewed By: reames Differential Revision: https://reviews.llvm.org/D135365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )