Dev/chargen #50
Merged
Dev/chargen #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly after first dismissal
…w interferes with React Error Boundary and makes it crash even harder
…ing render (but not for window.onError or for unhandled promise rejections--maybe in the future we can handle those cases)
…'t work yet, confuse the Fable-generated ctor. Updating to latest Fable didn't help but keeping the update anyway.
…rent error format
…s within budgeted
…ome mutually exclusive though (pick one!). Whether it's a checkbox or a div should depend on whether the PARENT is an either or an and', not on self. I.e. Sword! should have a checkbox next to it.
Apparently whether an option like a skill is a choice or not should be determined by its CONTEXT (i.e. parent) and not by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.