Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tgtg; Add local token store procedure #19

Merged
merged 12 commits into from
Nov 15, 2021
Merged

update tgtg; Add local token store procedure #19

merged 12 commits into from
Nov 15, 2021

Conversation

Dielee
Copy link
Collaborator

@Dielee Dielee commented Nov 15, 2021

Add local token store procedure to prevent repeated login emailing from tgtg.

@MaxWinterstein
Copy link
Owner

Awesome, thanks ❤️

One thing that crosses my mind when working on that from the other side (see https://github.com/MaxWinterstein/tgtg-python), what happens when I turn off the bridge for longer than the access_token_lifetime? I guess this case is not handled within tgtg and might end up in an exception loop?

@Dielee
Copy link
Collaborator Author

Dielee commented Nov 15, 2021

I am currently trying out what happens after expiration.
Possibly a new authorization can be done with the refresh_token.

Please wait with commiting until this case is safe!

@MaxWinterstein
Copy link
Owner

I am currently trying out what happens after expiration. Possibly a new authorization can be done with the refresh_token.

Please wait with commiting until this case is safe!

Great, let me know when it's done 😀

@Dielee
Copy link
Collaborator Author

Dielee commented Nov 15, 2021

So, refreshing token while running tgtg bot is working.
If the application is not running, the first loggin will always be done by credentials.

@MaxWinterstein
Copy link
Owner

nice 👍

will have a look and test in detail later.

@MaxWinterstein
Copy link
Owner

Works like a charm, thanks for the pull request!

@MaxWinterstein MaxWinterstein changed the title Add local token store procedure update tgtg; Add local token store procedure Nov 15, 2021
@MaxWinterstein MaxWinterstein merged commit 278c7b7 into MaxWinterstein:main Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants