Update htmlv2.pug - Fixed Top and Bottom Controllers not Activating, Added Per-Story ScrollSave Support, Fixed irresponsive layouts in Mobile view. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated how top and bottom controllers activate and deactivate in html. Use event.composedPath() instead of event.path.find(), which didn't work.
Fixed template errors.
Add per-story scrollsave support. Browsers treat file:// (desktop) and content:// (android) urls as from the same origin regadless the directory they're in. So if we have multiple stories downloaded, the scrollsave value is shared among them. By adding book id to the localStorage key, we can assure that scrollsave is specific to each story.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated how top and bottom controllers activate and deactivate in html.
Use event.composedPath() instead of event.path.find(), which didn't work.
Added word wrapping to part in css to avoid irresponsive layouts in Mobile view.
Add per-story scrollsave support.
Browsers treat file:// (desktop) and content:// (android) urls as from the same origin regadless the directory they're in. So if we have multiple stories downloaded, the scrollsave value is shared among them.
By adding book id to the localStorage key, we can assure that scrollsave is specific to each story.