Skip to content

Commit

Permalink
http: use strict comparison
Browse files Browse the repository at this point in the history
PR-URL: nodejs#17011
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
  • Loading branch information
leeseean authored and MayaLekova committed May 8, 2018
1 parent a845978 commit 3ffea8e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/_http_client.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const errors = require('internal/errors');
const INVALID_PATH_REGEX = /[^\u0021-\u00ff]/;

function validateHost(host, name) {
if (host != null && typeof host !== 'string') {
if (host !== null && host !== undefined && typeof host !== 'string') {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', `options.${name}`,
['string', 'undefined', 'null'], host);
}
Expand Down Expand Up @@ -113,7 +113,7 @@ function ClientRequest(options, cb) {

var method = options.method;
var methodIsString = (typeof method === 'string');
if (method != null && !methodIsString) {
if (method !== null && method !== undefined && !methodIsString) {
throw new errors.TypeError('ERR_INVALID_ARG_TYPE', 'method',
'string', method);
}
Expand Down

0 comments on commit 3ffea8e

Please sign in to comment.