src: Remove lttng support.

This cleans up and removes lttng support completely. Recent discussion
on a PR to deprecate lttng suggested that we remove it completely
pending feedback from the TSC.

This should be considered a non breaking change, as a recent PR reveals
that compiling with this system has been broken for nearly two years.

Refs: nodejs#18971
Refs: nodejs#18975
Refs: nodejs#18945

PR-URL: nodejs#18982
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

.eslintrc.js

@@ -263,12 +263,6 @@ module.exports = {
     DTRACE_HTTP_SERVER_RESPONSE: false,
     DTRACE_NET_SERVER_CONNECTION: false,
     DTRACE_NET_STREAM_END: false,
-    LTTNG_HTTP_CLIENT_REQUEST: false,
-    LTTNG_HTTP_CLIENT_RESPONSE: false,
-    LTTNG_HTTP_SERVER_REQUEST: false,
-    LTTNG_HTTP_SERVER_RESPONSE: false,
-    LTTNG_NET_SERVER_CONNECTION: false,
-    LTTNG_NET_STREAM_END: false,
     internalBinding: false,
   },
 };

configure

@@ -383,11 +383,6 @@ parser.add_option('--with-dtrace',
     dest='with_dtrace',
     help='build with DTrace (default is true on sunos and darwin)')
 
-parser.add_option('--with-lttng',
-    action='store_true',
-    dest='with_lttng',
-    help='build with Lttng (Only supported on Linux)')
-
 parser.add_option('--with-etw',
     action='store_true',
     dest='with_etw',
@@ -908,15 +903,6 @@ def configure_node(o):
   else:
     o['variables']['node_use_dtrace'] = 'false'
 
-  # Enable Lttng if --with-lttng was defined. Use logic similar to
-  # ETW for windows. Lttng is only available on the Linux platform.
-  if flavor == 'linux':
-    o['variables']['node_use_lttng'] = b(options.with_lttng)
-  elif options.with_lttng:
-    raise Exception('lttng is only supported on Linux.')
-  else:
-    o['variables']['node_use_lttng'] = 'false'
-
   if options.no_ifaddrs:
     o['defines'] += ['SUNOS_NO_IFADDRS']
 

deps/node-inspect/.eslintrc

@@ -139,9 +139,3 @@ globals:
   DTRACE_HTTP_SERVER_RESPONSE: false
   DTRACE_NET_SERVER_CONNECTION: false
   DTRACE_NET_STREAM_END: false
-  LTTNG_HTTP_CLIENT_REQUEST: false
-  LTTNG_HTTP_CLIENT_RESPONSE: false
-  LTTNG_HTTP_SERVER_REQUEST: false
-  LTTNG_HTTP_SERVER_RESPONSE: false
-  LTTNG_NET_SERVER_CONNECTION: false
-  LTTNG_NET_STREAM_END: false

doc/guides/contributing/pull-requests.md

@@ -146,7 +146,7 @@ A good commit message should describe what changed and why.
 
    Examples:
    - `net: add localAddress and localPort to Socket`
-   - `src: fix typos in node_lttng_provider.h`
+   - `src: fix typos in async_wrap.h`
 
 
 2. Keep the second line blank.

lib/_http_client.js

@@ -254,7 +254,6 @@ util.inherits(ClientRequest, OutgoingMessage);
 
 ClientRequest.prototype._finish = function _finish() {
   DTRACE_HTTP_CLIENT_REQUEST(this, this.connection);
-  LTTNG_HTTP_CLIENT_REQUEST(this, this.connection);
   COUNTER_HTTP_CLIENT_REQUEST();
   OutgoingMessage.prototype._finish.call(this);
 };
@@ -511,7 +510,6 @@ function parserOnIncomingClient(res, shouldKeepAlive) {
   }
 
   DTRACE_HTTP_CLIENT_RESPONSE(socket, req);
-  LTTNG_HTTP_CLIENT_RESPONSE(socket, req);
   COUNTER_HTTP_CLIENT_RESPONSE();
   req.res = res;
   res.req = req;

lib/_http_server.js

@@ -135,7 +135,6 @@ util.inherits(ServerResponse, OutgoingMessage);
 
 ServerResponse.prototype._finish = function _finish() {
   DTRACE_HTTP_SERVER_RESPONSE(this.connection);
-  LTTNG_HTTP_SERVER_RESPONSE(this.connection);
   COUNTER_HTTP_SERVER_RESPONSE();
   OutgoingMessage.prototype._finish.call(this);
 };
@@ -611,7 +610,6 @@ function parserOnIncoming(server, socket, state, req, keepAlive) {
 
   res.shouldKeepAlive = keepAlive;
   DTRACE_HTTP_SERVER_REQUEST(req, socket);
-  LTTNG_HTTP_SERVER_REQUEST(req, socket);
   COUNTER_HTTP_SERVER_REQUEST();
 
   if (socket._httpMessage) {

lib/net.js

@@ -506,7 +506,6 @@ Socket.prototype._read = function(n) {
 Socket.prototype.end = function(data, encoding, callback) {
   stream.Duplex.prototype.end.call(this, data, encoding, callback);
   DTRACE_NET_STREAM_END(this);
-  LTTNG_NET_STREAM_END(this);
   return this;
 };
 
@@ -1579,7 +1578,6 @@ function onconnection(err, clientHandle) {
   socket._server = self;
 
   DTRACE_NET_SERVER_CONNECTION(socket);
-  LTTNG_NET_SERVER_CONNECTION(socket);
   COUNTER_NET_SERVER_CONNECTION(socket);
   self.emit('connection', socket);
 }

node.gyp

@@ -3,7 +3,6 @@
     'v8_use_snapshot%': 'false',
     'v8_trace_maps%': 0,
     'node_use_dtrace%': 'false',
-    'node_use_lttng%': 'false',
     'node_use_etw%': 'false',
     'node_use_perfctr%': 'false',
     'node_no_browser_globals%': 'false',
@@ -530,19 +529,6 @@
             }],
           ],
         }],
-        [ 'node_use_lttng=="true"', {
-          'defines': [ 'HAVE_LTTNG=1' ],
-          'include_dirs': [ '<(SHARED_INTERMEDIATE_DIR)' ],
-          'libraries': [ '-llttng-ust' ],
-          'include_dirs': [
-            'src',
-            'tools/msvs/genfiles',
-            '<(SHARED_INTERMEDIATE_DIR)' # for node_natives.h
-          ],
-          'sources': [
-            'src/node_lttng.cc'
-          ],
-        }],
         [ 'node_use_dtrace=="true"', {
           'defines': [ 'HAVE_DTRACE=1' ],
           'dependencies': [
@@ -736,9 +722,6 @@
             [ 'node_use_dtrace=="false" and node_use_etw=="false"', {
               'inputs': [ 'src/notrace_macros.py' ]
             }],
-            [ 'node_use_lttng=="false"', {
-              'inputs': [ 'src/nolttng_macros.py' ]
-            }],
             [ 'node_use_perfctr=="false"', {
               'inputs': [ 'src/noperfctr_macros.py' ]
             }]

src/node.cc

@@ -49,10 +49,6 @@
 #include "node_dtrace.h"
 #endif
 
-#if defined HAVE_LTTNG
-#include "node_lttng.h"
-#endif
-
 #include "ares.h"
 #include "async_wrap-inl.h"
 #include "env-inl.h"
@@ -3340,10 +3336,6 @@ void LoadEnvironment(Environment* env) {
   InitDTrace(env, global);
 #endif
 
-#if defined HAVE_LTTNG
-  InitLTTNG(env, global);
-#endif
-
 #if defined HAVE_PERFCTR
   InitPerfCounters(env, global);
 #endif