-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#2): implement pagination component and add it to pages #57
Conversation
@luko0610 There are some conflicts as I recently merged a PR, so kindly pull it to your forked repo and then commit. |
@luko0610 Another thing that can you send me screenshots of how the pagination is looking after you implemented them? and is it responsive as well? It would be really helpful in reviewing it that way |
…ing pages: - Posts - Users - Tags
If already on last page the next button is disabled. |
@luko0610 try this out for the styling of the components https://stackoverflow.design/product/guidelines/using-stacks/ This is officially provided by stackoverflow and the basic setup has already been done and used in some places, so you can just use this. Like you can use this for the buttons, so that it matches exactly with the real one |
…till needs some refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have deleted the styles file as that was now empty, now the rest of the code is perfect 👍🏽
I had a request to make that as Hacktoberfest has only one week left, I am planning to do a tweet on twitter at the end of the month congratulating all the contributors and giving them a special mention for there efforts, To do this I would like you to do the steps below so that it becomes easy for me to document,
I hope to receive a favorable reply 🎉 |
@luko0610 Any updates on this? |
Implemented pagination component and added it to the following pages:
closes #2