Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2): implement pagination component and add it to pages #57

Merged
merged 4 commits into from
Oct 12, 2021
Merged

feat(#2): implement pagination component and add it to pages #57

merged 4 commits into from
Oct 12, 2021

Conversation

luko0610
Copy link
Contributor

@luko0610 luko0610 commented Oct 9, 2021

Implemented pagination component and added it to the following pages:

  • Posts
  • Users
  • Tags

closes #2

@Mayank0255
Copy link
Owner

@luko0610 There are some conflicts as I recently merged a PR, so kindly pull it to your forked repo and then commit.

@Mayank0255
Copy link
Owner

@luko0610 Another thing that can you send me screenshots of how the pagination is looking after you implemented them? and is it responsive as well?

It would be really helpful in reviewing it that way

@Mayank0255 Mayank0255 changed the title FEATURE - Implemented pagination component and added it to pages. feat(#2): implement pagination component and add it to pages Oct 10, 2021
@luko0610
Copy link
Contributor Author

luko0610 commented Oct 10, 2021

@Mayank0255
image
image

If already on last page the next button is disabled.
Should also be responsive.

@Mayank0255
Copy link
Owner

@luko0610 try this out for the styling of the components https://stackoverflow.design/product/guidelines/using-stacks/

This is officially provided by stackoverflow and the basic setup has already been done and used in some places, so you can just use this. Like you can use this for the buttons, so that it matches exactly with the real one

Copy link
Owner

@Mayank0255 Mayank0255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted the styles file as that was now empty, now the rest of the code is perfect 👍🏽

@Mayank0255 Mayank0255 merged commit 7c3b294 into Mayank0255:master Oct 12, 2021
@Mayank0255
Copy link
Owner

@luko0610,

I had a request to make that as Hacktoberfest has only one week left, I am planning to do a tweet on twitter at the end of the month congratulating all the contributors and giving them a special mention for there efforts,

To do this I would like you to do the steps below so that it becomes easy for me to document,

  1. Follow me on Mayank0255
  2. Text me on twitter itself so that I have your twitter handles.
  3. In the text mention three things-
    • Github Handle Link
    • Name of the project you worked with me

I hope to receive a favorable reply 🎉

@Mayank0255
Copy link
Owner

@luko0610,

I had a request to make that as Hacktoberfest has only one week left, I am planning to do a tweet on twitter at the end of the month congratulating all the contributors and giving them a special mention for there efforts,

To do this I would like you to do the steps below so that it becomes easy for me to document,

  1. Follow me on Mayank0255

  2. Text me on twitter itself so that I have your twitter handles.

  3. In the text mention three things-

    • Github Handle Link
    • Name of the project you worked with me

I hope to receive a favorable reply 🎉

@luko0610 Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend]: Implement pagination to the App
2 participants