Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps to support description in SDL #111

Closed
wants to merge 2 commits into from

Conversation

tgriesser
Copy link

Descriptions are now correctly defined/parsed as quoted strings preceding the node.

ArgumentsOfCorrectType became ValuesOfCorrectType in 0.12

Upgraded dependencies:

  • graphql-language-service-interface: 0.0.11 -> 1.0.18
  • graphql-language-service-parser: 0.0.10 -> 1.0.18
  • graphql: 0.9.6 -> 0.12.3
  • apollo-codegen: 0.10.13 -> 0.18.8

Descriptions are now correctly defined/parsed as quoted strings
preceding the node.

ArgumentsOfCorrectType became ValuesOfCorrectType in 0.12

Upgraded dependencies:
- graphql-language-service-interface: 0.0.11 -> 1.0.18
- graphql-language-service-parser: 0.0.10 -> 1.0.18
- graphql: 0.9.6 -> 0.12.3
- apollo-codegen:  0.10.13 -> 0.18.8
@tgriesser
Copy link
Author

This PR is an attempt to get rid of the errors I'm seeing when using the new description syntax in my GraphQL schema definition file. I've been working the changes on this branch locally and it seems to do the trick.

screen shot 2018-03-05 at 11 08 06 am
screen shot 2018-03-05 at 11 07 23 am

@codecov
Copy link

codecov bot commented Mar 5, 2018

Codecov Report

Merging #111 into master will decrease coverage by 0.77%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   85.98%   85.21%   -0.78%     
==========================================
  Files          54       54              
  Lines        1320     1305      -15     
==========================================
- Hits         1135     1112      -23     
- Misses        185      193       +8

@Mayank1791989
Copy link
Owner

Hi @tgriesser thanks for the PR.

But there are few issues with graphql >0.12.x

  • as description becomes part of ast the current printer will not print correctly
    (info shown in tooltips will be broken).
  • also it will break the old comment description syntax.

The proper fix is already in v3 branch (I will try to release it as soon as possible). For now anyone who is using the new description can use your fork to avoid parsing error.

@ajhyndman
Copy link

@Mayank1791989 Are you interested in any contributions assisting with the v3 project? Is there any way we can help keep that moving?

@ntziolis
Copy link

ntziolis commented Apr 18, 2018

@Mayank1791989 Is there any update on v3, sadly the entire GrsaphQL for vscode extension has become rather useless when not being able to use the latest graphql libs. Happy to jump in and help push this thorough just lmk when you need assistance as this is a core dev tool for us which right now does not work since weeks

@tgriesser
Copy link
Author

I just upgraded this to GraphQL 0.13, anyone that needs it can use

"@playlyfe/gql": "tgriesser/gql.git#upgrade-deps-published-0.13",

in their package.json

@tgriesser
Copy link
Author

Nevermind, the changes here seem to break things, couldn't figure out why exactly. I think it might have to do with the fact that the language service is still on ^0.12?

Anyway, closing this since it's not going to be merged as is.

Looks like there's some good work being done on the graphql-for-vscode related to this. Looking forward to it!

@tgriesser tgriesser closed this May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants