Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] New collection member checks existing collections for 1 member #35

Closed
Mayyhem opened this issue Aug 23, 2023 · 0 comments
Closed

[BUG] New collection member checks existing collections for 1 member #35

Mayyhem opened this issue Aug 23, 2023 · 0 comments
Assignees
@Mayyhem
Labels
bug Something isn't working

Comments

@Mayyhem
Copy link
Owner

Mayyhem commented Aug 23, 2023

Describe the bug

BadSectorLabs
12:03 PM
I think this is a bug. You only check if the member count is equal to 1, but you could be adding a second device (which instantly reports succes) or 3+ devices which will never satisfy this check. Perhaps better to check that the device is in the group members like you do above? https://github.com/Mayyhem/SharpSCCM/blob/d2dd01fa58f3e168d34611b249579aa848b7ea97/lib/MgmtPointWmi.cs#L1036C53-L1036C53
@Mayyhem Mayyhem added the bug Something isn't working label Aug 23, 2023
@Mayyhem Mayyhem self-assigned this Aug 23, 2023
Mayyhem added a commit that referenced this issue Jan 31, 2024
@Mayyhem
Fixed issue #35
9161812
@Mayyhem Mayyhem mentioned this issue Jan 31, 2024
Merged
7 tasks
Mayyhem added a commit that referenced this issue Jan 31, 2024
@Mayyhem
Merge pull request #50 from Mayyhem/issue-35
ee5f907 
Fix Issue #35
@Mayyhem Mayyhem closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mayyhem Mayyhem

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mayyhem