This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
Fixes #24 #32
Open
nikolauskrismer
wants to merge
19
commits into
MazeMap:master
Choose a base branch
from
nikolauskrismer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes #24 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to changes from otg-drmc/Leaflet.TileLayer.PouchDBCached, but with scoping
This allows passing options to PouchDB when it's created. This code is copied from `github.com/kwibus/Leaflet.TileLayer.PouchDBCached` and applied to the codebase of `github.com/nikolauskrismer/Leaflet.TileLayer.PouchDBCached`, thus effectively merging several pull requests that have not yet been accepted to the original base repository.
Added dbOptions to allow changing PouchDB options
schloerke
added a commit
to schloerke/leaflet.extras
that referenced
this pull request
Mar 20, 2018
use this PR as the new leaflet.tilelayer.pouchdbcached MazeMap/Leaflet.TileLayer.PouchDBCached#32
fixing link to leaflet bug
fixing link to leaflet issue
adding missing closing bracket
Seeding demo is integrated into "general demo" by now...
IvanSanchez
previously requested changes
Nov 16, 2018
package.json
Outdated
"license": "MIT", | ||
"bugs": { | ||
"url": "https://github.com/MazeMap/Leaflet.TileLayer.PouchDBCached/issues" | ||
"url": "https://github.com/nikolauskrismer/Leaflet.TileLayer.PouchDBCached/issues" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to merge this, but only if the repo would be kept the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted this
Any update on this PR? |
nikolauskrismer
dismissed
IvanSanchez’s stale review
June 25, 2020 19:43
Changes have been made, to reflect the comments made
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility for CouchDB 6.x implemented (with scoping issues resolved)