Fix GCC 15 warning 'Wunterminated-string-initialization' #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization warning Signed-off-by: Felix Conway <felix.conway@arm.com>
5 tasks
…MINATED_STRING This macro applies __attribute__((nonstring)) when the compiler supports it Signed-off-by: Felix Conway <felix.conway@arm.com>
This was referenced Jun 12, 2025
felixc-arm
added
needs-review
gilles-peskine-arm
approved these changes
Jun 12, 2025
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
This change is correct once Mbed-TLS/mbedtls#10215 and Mbed-TLS/TF-PSA-Crypto#313 are merged and mbedtls/development picks up the crypto merge. I think it's complete based on the warnings seen in a 3.6 test run.
| psa_key_type_t key_type; | ||
| const unsigned char plaintext[16] = "Hello, world..."; | ||
| unsigned char ciphertext[32] = "(wabblewebblewibblewobblewubble)"; | ||
| /* We need to tell the compiler that we meant to leave out the null character. */ |
Contributor
There was a problem hiding this comment.
I don't find this comment useful (MBEDTLS_ATTRIBUTE_UNTERMINATED_STRING already says it), but I don't mind having it.
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
mpg
added
approved
davidhorstmann-arm
removed
the
needs-preceding-pr
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
This was referenced Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
framework part of and resolves Mbed-TLS/mbedtls#9944
Depends on Mbed-TLS/mbedtls#10215, Mbed-TLS/TF-PSA-Crypto#313 & Mbed-TLS/mbedtls#10216
Merge order:
Merge the
TF-PSA-CryptoPR Mbed-TLS/TF-PSA-Crypto#313Update the
tf-psa-cryptosubmodule pointer on thembedtlsdevelopment PR (Mbed-TLS/mbedtls#10216) to the merge commit of theTF-PSA-CryptoPRMerge the
mbedtlsdevelopment PR(Independently) Merge the 3.6
mbedtlsPR Mbed-TLS/mbedtls#10215Then replay or re-trigger the CI, which will pick up the required changes in
mbedtlsdevelopment andmbedtls3.6 and then should be green.PR checklist