Add project and branch detection in shell #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleuzi01
added
enhancement
This was referenced Nov 7, 2024
eleuzi01
force-pushed
the
issue-39
branch
2 times, most recently
from
76f2ecc to
830209b
Compare
eleuzi01
added
needs-review
mpg
reviewed
Nov 12, 2024
scripts/project_detection.sh
Outdated
|
|
||
| PROJECT_NAME_FILE="scripts/project_name.txt" | ||
|
|
||
| if echo "$SCRIPT_DIR" | grep -q "/framework/scripts" || echo "$SCRIPT_DIR" | grep -q "/tests/scripts"; then |
There was a problem hiding this comment.
Seems unnecessary if we assume the scripts are always invoked from the project's root (which as I said on the other PR, is a standard assumption - too bad it's often unwritten).
eleuzi01
force-pushed
the
issue-39
branch
3 times, most recently
from
7408b3e to
b1eee49
Compare
It might have to be done in a following PR because the CI is not passing when I do that. Either I'm doing something wrong or maybe there're still PRs that have to be merged before I'm able to remove this temporary solution? |
Move in_mbedtls_repo() and in_tf_psa_repo() there Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Because the scripts are always invoked from the project's root Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
This reverts commit b1eee49. Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
davidhorstmann-arm
approved these changes
Nov 27, 2024
davidhorstmann-arm
removed
needs-review
davidhorstmann-arm
added
the
approved
This was referenced Nov 28, 2024
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #39
Development: Mbed-TLS/mbedtls#9763
3.6: Mbed-TLS/mbedtls#9764
Gatekeper note (mpg): CI can't pass here as we now depend on the
FRAMEWORKvariables defined by the associated PRs. So, we'll rely on CI status in 9763 and 9764. We also need to merge the 3 PRs at the same time in order to avoid breakage - so we won't do the usual pointer update in 9763 and 9764 after merging this one in order to reduce the window where things are in an inconsistent state. (We can update the pointer to the merge commit as follow-ups to 9763 and 9764.)