Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "easy" basic checks scripts to the framework #95

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Dec 5, 2024

Resolves #69.

development PR: Mbed-TLS/mbedtls#9825
mbedtls-3.6 PR: Mbed-TLS/mbedtls#9826

@eleuzi01 eleuzi01 assigned eleuzi01 and unassigned eleuzi01 Dec 9, 2024
@eleuzi01 eleuzi01 self-requested a review December 9, 2024 13:15
@eleuzi01 eleuzi01 added enhancement New feature or request needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) size-s Estimated task size: small (~2d) and removed size-xs Estimated task size: extra small (a few hours at most) labels Dec 9, 2024
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
@eleuzi01
Copy link
Contributor

eleuzi01 commented Dec 9, 2024

Looks good, however given this #80 (comment) might need to move files from tests/scripts to just scripts

Signed-off-by: Elena Uziunaite <elena.uziunaite@arm.com>
Move scripts used by all-core.sh to the framework
valeriosetti and others added 2 commits December 10, 2024 16:43
The following files are added (imported) from the main Mbed TLS repo:

scripts/assemble_changelog.py
scripts/check-doxy-blocks.pl
scripts/check-python-files.sh
scripts/doxygen.sh
scripts/apidoc_full.sh
scripts/recursion.pl

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>
# When the recursion depth might depend on data controlled by the attacker in
# an unbounded way, those functions should use iteration instead.
#
# Typical usage: scripts/recursion.pl library/*.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be

Suggested change
# Typical usage: scripts/recursion.pl library/*.c
# Typical usage: framework/scripts/recursion.pl library/*.c

now that it's moved?

Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Development

Successfully merging this pull request may close these issues.

Move "easy" basic checks scripts to the framework
3 participants