Skip to content

Commit 2cd2fae

Browse files
Merge pull request #10470 from Begasus/mbedtls-3.6
Use GNUInstallDirs CMAKE_INSTALL_INCLUDEDIR path for headers installation
2 parents d80b9ff + 7a399a6 commit 2cd2fae

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

3rdparty/everest/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ add_library(${everest_target}
88
target_include_directories(${everest_target}
99
PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
1010
$<BUILD_INTERFACE:${MBEDTLS_DIR}/include>
11-
$<INSTALL_INTERFACE:include>
11+
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
1212
PRIVATE include/everest
1313
include/everest/kremlib
1414
${MBEDTLS_DIR}/library/)
@@ -29,7 +29,7 @@ endif()
2929
if(INSTALL_MBEDTLS_HEADERS)
3030

3131
install(DIRECTORY include/everest
32-
DESTINATION include
32+
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
3333
FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
3434
DIRECTORY_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
3535
FILES_MATCHING PATTERN "*.h")

3rdparty/p256-m/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ target_include_directories(${p256m_target}
88
PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
99
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/p256-m>
1010
$<BUILD_INTERFACE:${MBEDTLS_DIR}/include>
11-
$<INSTALL_INTERFACE:include>
11+
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
1212
PRIVATE ${MBEDTLS_DIR}/library/)
1313

1414
# Pass-through MBEDTLS_CONFIG_FILE and MBEDTLS_USER_CONFIG_FILE
@@ -27,7 +27,7 @@ endif()
2727
if(INSTALL_MBEDTLS_HEADERS)
2828

2929
install(DIRECTORY :${CMAKE_CURRENT_SOURCE_DIR}
30-
DESTINATION include
30+
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
3131
FILE_PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
3232
DIRECTORY_PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
3333
FILES_MATCHING PATTERN "*.h")
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Bugfix
2+
* CMake now installs headers to `CMAKE_INSTALL_INCLUDEDIR` instead of the
3+
hard-coded `include` directory.

include/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ if(INSTALL_MBEDTLS_HEADERS)
66
file(GLOB psa_headers "psa/*.h")
77

88
install(FILES ${headers}
9-
DESTINATION include/mbedtls
9+
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/mbedtls
1010
PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ)
1111

1212
install(FILES ${psa_headers}
13-
DESTINATION include/psa
13+
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/psa
1414
PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ)
1515

1616
endif(INSTALL_MBEDTLS_HEADERS)

library/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ foreach(target IN LISTS target_libraries)
349349
# of /library (which currently means: under /3rdparty).
350350
target_include_directories(${target}
351351
PUBLIC $<BUILD_INTERFACE:${MBEDTLS_DIR}/include/>
352-
$<INSTALL_INTERFACE:include/>
352+
$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
353353
PRIVATE ${MBEDTLS_DIR}/library/
354354
# Needed to include psa_crypto_driver_wrappers.h
355355
${CMAKE_CURRENT_BINARY_DIR})

0 commit comments

Comments
 (0)