Use GNUInstallDirs CMAKE_INSTALL_INCLUDEDIR path for headers installation

[Begasus]

Description

Using a hardcoded path like "include" for headers path doesn't follow GNUInstallDirs method.

PR checklist

• changelog provided
• framework PR not required
• mbedtls development PR provided Use GNUInstallDirs CMAKE_INSTALL_INCLUDEDDIR path for headers installation #10469
• mbedtls 3.6 PR provided here
• tests not required because: The installation process is exercised by programs/test/cmake_package_install.

[Begasus]

@ronald-cron-arm could you check if this is OK? If so I could copy this to the other PR's.

[ronald-cron-arm]

Some formatting issue with the change log. Otherwise while working on CMAKE_INSTALL_INCLUDEDIR, isn't it the case that in library/CMakeLists.txt line 350 and following we should have:

    target_include_directories(${target}                                        
        PUBLIC $<BUILD_INTERFACE:${MBEDTLS_DIR}/include/>                       
               $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>                 
        PRIVATE ${MBEDTLS_DIR}/library/                                         
                # Needed to include psa_crypto_driver_wrappers.h                
                ${CMAKE_CURRENT_BINARY_DIR})

instead of

    target_include_directories(${target}                                        
        PUBLIC $<BUILD_INTERFACE:${MBEDTLS_DIR}/include/>                       
               $<INSTALL_INTERFACE:include/>                 
        PRIVATE ${MBEDTLS_DIR}/library/                                         
                # Needed to include psa_crypto_driver_wrappers.h                
                ${CMAKE_CURRENT_BINARY_DIR})

?

[Begasus]

Some formatting issue with the change log. Otherwise while working on CMAKE_INSTALL_INCLUDEDIR, isn't it the case that in library/CMakeLists.txt line 350 and following we should have:

    target_include_directories(${target}                                        
        PUBLIC $<BUILD_INTERFACE:${MBEDTLS_DIR}/include/>                       
               $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>                 
        PRIVATE ${MBEDTLS_DIR}/library/                                         
                # Needed to include psa_crypto_driver_wrappers.h                
                ${CMAKE_CURRENT_BINARY_DIR})

instead of

    target_include_directories(${target}                                        
        PUBLIC $<BUILD_INTERFACE:${MBEDTLS_DIR}/include/>                       
               $<INSTALL_INTERFACE:include/>                 
        PRIVATE ${MBEDTLS_DIR}/library/                                         
                # Needed to include psa_crypto_driver_wrappers.h                
                ${CMAKE_CURRENT_BINARY_DIR})

?

I guess this should be it?

[ronald-cron-arm]

LGTM, thanks.

[minosgalanakis]

LGTM