Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design how to access the fields of mbedtls_ecp_keypair and mbedtls_ecdsa_context #5017

Closed
gabor-mezei-arm opened this issue Oct 5, 2021 · 1 comment · Fixed by #7815
Closed
Assignees
Labels
component-crypto Crypto primitives and low-level interfaces enhancement needs-design-approval size-s Estimated task size: small (~2d)

Comments

@gabor-mezei-arm
Copy link
Contributor

gabor-mezei-arm commented Oct 5, 2021

This is a design task, as part of #4683 and #5441, to solve the private field access of mbedtls_ecp_keypair (and inclusively mbedtls_ecdsa_context) by MBEDTLS_PRIVATE macro in programs.

Possible option to solve the private access:

  1. Make the private fields public
    • good for inner structures
    • locks the representation of the built-in typed data
  2. Create getter and setter APIs for field access
    • locks the representation of the built-in typed data
    • requires more memory and more CPU time
  3. Some mixture of the previous two option. Some fields are public, some are using getter and setter APIs

The advantages and downsides of this problem explained in detail here.

This is intended to be the design task and the implementation should be done in #4838.

@paul-elliott-arm
Copy link
Member

ECP Keypair export function added in #5642 as per discussion in #4838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-crypto Crypto primitives and low-level interfaces enhancement needs-design-approval size-s Estimated task size: small (~2d)
Projects
Status: [3.6] Mbed TLS PRIVATE
Development

Successfully merging a pull request may close this issue.

5 participants