Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessor (getter/setter) function for mbedtls_ecp_keypair #8367

Closed
priyamourya25 opened this issue Oct 16, 2023 · 2 comments · Fixed by #7815
Closed

Add accessor (getter/setter) function for mbedtls_ecp_keypair #8367

priyamourya25 opened this issue Oct 16, 2023 · 2 comments · Fixed by #7815
Labels
component-tls enhancement needs-info An issue or PR which needs further info from the reporter / author priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)

Comments

@priyamourya25
Copy link

Suggested enhancement

Please add getter setter functions for members of struct mbedtls_ecp_keypair which are private now.

Justification

These can be used to pass the group using mbedtls_ecp_group_load() API. Because members like "grp" are private, it can not be passed to load API without enabling private access.

Mbed TLS needs this because we can then use the load API with the group in mbedtls_ecp_keypair.

@gilles-peskine-arm
Copy link
Contributor

We would prefer not to make the fields public, because that prevents us from improving support for platforms that have an ECC accelerator. We do recognize that the current API has gaps, however: we were planning improvements shortly after the 3.0 release, but they dropped off the radar.

We now hope to get #7815 into the next release of Mbed TLS (3.6). Would that work for you? If not, could you please describe more precisely what you want to do with mbedtls_ecp_keypair object? Basically what you can do with MBEDTLS_PRIVATE but want to do without.

@minosgalanakis minosgalanakis added enhancement component-tls size-s Estimated task size: small (~2d) needs-info An issue or PR which needs further info from the reporter / author priority-high High priority - will be reviewed soon labels Nov 13, 2023
@minosgalanakis
Copy link
Contributor

Closing as a duplicate of #4838. ecp_export link can be used to extract the required fields.

Should that no be sufficient, please follow-up and comment on the actively workeed design issue #5017 dealing with the subject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-tls enhancement needs-info An issue or PR which needs further info from the reporter / author priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Status: [3.6] Mbed TLS PRIVATE
Development

Successfully merging a pull request may close this issue.

3 participants