Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests disable dued to old OpenSSL bug #5077

Closed
mpg opened this issue Oct 14, 2021 · 0 comments · Fixed by #5985 or #5990
Closed

Re-enable tests disable dued to old OpenSSL bug #5077

mpg opened this issue Oct 14, 2021 · 0 comments · Fixed by #5985 or #5990
Assignees
@zhangsenWang
Labels
size-s Estimated task size: small (~2d)

Comments

@mpg
Copy link
Contributor

mpg commented Oct 14, 2021

Suggested enhancement

In tests/ssl-opt.sh there are 5 cases that are disabled due to a bug in OpenSSL. It appears that this bug has been fixed in OpenSSL 1.1.1a which is available on the CI machines as "OpenSSL next".

So, we can and should now re-enable those test by using $O_NEXT_SRV (and requires_openssl_next). The comments should be updated accordingly, but not removed entirely, so we know exactly why we're using that version.

Justification

Mbed TLS needs this because testing!
@mpg mpg changed the title Re-enable tests disable due to OpenSSL bug Re-enable tests disable dued to old OpenSSL bug Oct 14, 2021
@mpg mpg added Product Backlog size-s Estimated task size: small (~2d) labels Oct 14, 2021
zhangsenWang added a commit to zhangsenWang/mbedtls that referenced this issue Jun 28, 2022
@zhangsenWang
Mbed-TLS#5077
dfee3c1
zhangsenWang added a commit to zhangsenWang/mbedtls that referenced this issue Jun 28, 2022
@zhangsenWang
Mbed-TLS#5077
3ecfd5c 
Signed-off-by: Zhangsen Wang <zhangsen.wang@arm.com>
@minosgalanakis minosgalanakis linked a pull request Jun 28, 2022 that will close this issue
Re-enable four tests disabled because of an old OpenSSL bug #5985
Merged
@minosgalanakis minosgalanakis mentioned this issue Jun 28, 2022
Merged
@zhangsenWang zhangsenWang mentioned this issue Jun 29, 2022
Merged
@zhangsenWang zhangsenWang linked a pull request Jun 29, 2022 that will close this issue
Backport 2.28: Re-enable 5 tests disabled because of an old OpenSSL bug #5990
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhangsenWang zhangsenWang

Labels
size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
4 participants
@mpg @daverodgman @bensze01 @zhangsenWang