Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing accessor for mbedtls_x509_crt.ext_types for uacme #5585

Closed
6 tasks done
ndilieto opened this issue Feb 27, 2022 · 1 comment · Fixed by #5887
Closed
6 tasks done

Add missing accessor for mbedtls_x509_crt.ext_types for uacme #5585

ndilieto opened this issue Feb 27, 2022 · 1 comment · Fixed by #5887
Assignees
Labels
component-x509 enhancement size-s Estimated task size: small (~2d)

Comments

@ndilieto
Copy link
Contributor

ndilieto commented Feb 27, 2022

Suggested enhancement

Add missing accessor functions to the following

  • 1) mbedtls_ecp_keypair.MBEDTLS_PRIVATE(grp)
  • 2) mbedtls_ecp_keypair.MBEDTLS_PRIVATE(Q)
  • 3) mbedtls_x509_crt.MBEDTLS_PRIVATE(ext_types)
  • 4) mbedtls_pem_context.MBEDTLS_PRIVATE(buf)
  • 5) mbedtls_pem_context.MBEDTLS_PRIVATE(buflen)
  • 6) SSL.MBEDTLS_PRIVATE(state)

Edit: For 1) and 2) a new mbedtls_ec_export function could be introduced, similar to mbedtls_rsa_export which already exists.

Justification

Commit ndilieto/uacme@64d1b3c adds support for mbedTLS v3.0 to uacme, but accessor functions to the above are missing and therefore I had to resort to MBEDTLS_PRIVATE.

@daverodgman
Copy link
Contributor

The first two (ECP keypair) are covered by #4838. 4 & 5 (PEM context) are covered by #5414 (fix merged in #5504). 6 (SSL handshake state) is covered by #4383. So I think the only new item is relating to mbedtls_x509_crt.ext_types (I'll rename this issue for clarity).

@daverodgman daverodgman changed the title Add missing accessor functions for uacme Add missing accessor for mbedtls_x509_crt.ext_types for uacme Feb 28, 2022
@daverodgman daverodgman added component-x509 enhancement size-s Estimated task size: small (~2d) labels Feb 28, 2022
@tom-daubney-arm tom-daubney-arm self-assigned this Apr 13, 2022
ndilieto added a commit to ndilieto/uacme that referenced this issue Jun 12, 2022
Clean up following completion of

Mbed-TLS/mbedtls#5585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-x509 enhancement size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants