-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure with PSA and RSA but not PK_PARSE #6409
Labels
bug
component-crypto
Crypto primitives and low-level interfaces
size-s
Estimated task size: small (~2d)
Comments
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbedtls
that referenced
this issue
Oct 11, 2022
Disable non-crypto features that can't be called through the PSA API, as well as algorithms that have no PSA interface. This serves as a non-regression test for Mbed-TLS#6408 and Mbed-TLS#6409. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbedtls
that referenced
this issue
Oct 11, 2022
PSA crypto currently needs MBEDTLS_PK_PARSE_C to parse RSA keys to do almost anything with them (import, get attributes, export public from private, any cryptographic operations). Force it on, for symmetry with what we're doing for MBEDTLS_PK_WRITE_C. Fixes Mbed-TLS#6409. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbedtls
that referenced
this issue
Oct 25, 2022
The PSA code needs pk_parse as well as pk_write for RSA keys. Fix Mbed-TLS#6409. This is independent of PKCS#1v1.5 support. Fix Mbed-TLS#6408. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbedtls
that referenced
this issue
Oct 25, 2022
Disable non-crypto features that can't be called through the PSA API, as well as algorithms that have no PSA interface. This serves as a non-regression test for Mbed-TLS#6408 and Mbed-TLS#6409. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added a commit
to gilles-peskine-arm/mbedtls
that referenced
this issue
Oct 25, 2022
Disable non-crypto features that can't be called through the PSA API, as well as algorithms that have no PSA interface. This serves as a non-regression test for Mbed-TLS#6408 and Mbed-TLS#6409. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
component-crypto
Crypto primitives and low-level interfaces
size-s
Estimated task size: small (~2d)
When
MBEDTLS_PSA_CRYPTO_C
andMBEDTLS_RSA_C
are enabled but notMBEDTLS_PK_PARSE_C
, the build fails, because PSA relies on pk_parse functions to load RSA keys.This applies to both 2.28 and development.
This hasn't worked since at least 2.24 when we changed the internal representation of RSA keys (and even before that I think it would only have worked for internally generated volatile keys, with runtime errors for key import or persistent keys).
The quick fix is to add a requirement in
check_config.h
. In development, we might do what we're already partially doing (though not quite correctly) forMBEDTLS_PK_WRITE_C
, which is to force it on when required inbuild_info.h
.The text was updated successfully, but these errors were encountered: