Backport 3.6: Check union initialization portably #10179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-backports
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
This was referenced May 15, 2025
When initializing a multipart or interruptible operation structure, use an
auxiliary function that doesn't initialize union members to all-bits-zero.
Context: on most compilers, initializing a union to `{0}` initializes it to
all bits zero; but on some compilers, the trailing part of members other
than the first is left uninitialized. This way, we can run the tests on any
platform and validate that the code would work correctly on platforms where
union initialization is short.
This commit makes a systematic replacement in `test_suite_psa_crypto.function`
and `test_suite_psa_crypto_driver_wrappers.function`, which gives good
enough coverage.
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Partially undo "Use short initializers for multipart operation structures", only in test functions that specifically aim to test initializers. In these functions, do try with the short initializers, but alongside the standard ones. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
union-initialization-gcc15-driver-checks-3.6
branch
from
e359e63 to
821a5db
Compare
gilles-peskine-arm
added
needs-review
4 tasks
mpg
reviewed
Jun 3, 2025
Contributor
mpg
left a comment
mpg
left a comment
There was a problem hiding this comment.
LGTM, but I guess the framework pointer should be updated to the merge commit of Mbed-TLS/mbedtls-framework#168 (currently pointing at the tip of the associated branch).
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
union-initialization-gcc15-driver-checks-3.6
branch
from
821a5db to
0050f5f
Compare
Contributor
Author
|
I've amended the last commit to update the framework submodule to the head of main instead of the now-merged pull request branch. |
github-project-automation
bot
moved this from In Development
to Has Approval
in Roadmap pull requests (new board)
gabor-mezei-arm
removed
the
needs-review
gabor-mezei-arm
added
the
approved
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved testing for #9814 and #9975:
HMAC-SHA-256test failures on upcominggcc-15(after partial union initialization changes) #9814.HMAC-SHA-256test failures on upcominggcc-15(after partial union initialization changes) #9814.Needs preceding PR:
PR checklist