Improve detection of CMake library installation problems #10239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronald-cron-arm
force-pushed
the
mbedtls-build-info-last
branch
from
f715ee8 to
d47ace1
Compare
4 tasks
ronald-cron-arm
added
needs-ci
davidhorstmann-arm
previously approved these changes
Jun 20, 2025
Contributor
There was a problem hiding this comment.
LGTM but CI is unhappy
[Edit: Looks infra-related except for the API-ABI check, which is picking up the updated crypto submodule with a change to how PAKE struct types are used from #10200]
Fail the cmake package install demonstration in case of warnings when building the cmake_package_install executable. This would have caught the library installation issue reported in Mbed-TLS#10022. Signed-off-by: Ronald Cron <ronald.cron@arm.com>
ronald-cron-arm
force-pushed
the
mbedtls-build-info-last
branch
from
d47ace1 to
2fc0475
Compare
ronald-cron-arm
changed the title
ronald-cron-arm
added
enhancement
needs-ci
github-project-automation
bot
moved this to In Development
in Roadmap pull requests (new board)
ronald-cron-arm
added
needs-review
ronald-cron-arm
moved this from In Development
to In Review
in Roadmap pull requests (new board)
davidhorstmann-arm
removed
needs-review
davidhorstmann-arm
approved these changes
Aug 27, 2025
Contributor
davidhorstmann-arm
left a comment
davidhorstmann-arm
left a comment
There was a problem hiding this comment.
LGTM, thanks!
github-project-automation
bot
moved this from In Review
to Has Approval
in Roadmap pull requests (new board)
davidhorstmann-arm
added
the
approved
github-project-automation
bot
moved this from Has Approval
to Done
in Roadmap pull requests (new board)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building cmake_package_install, fail in case of warnings with GNU GCC. This would have caught the issue reported in #10022.
PR checklist