Skip to content

Fix documentation link to submodule that doesn't work on GitHub #10459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

Fix documentation link to submodule that doesn't work on GitHub #10459

merged 1 commit into from
Oct 17, 2025
+1 −1

Conversation

@gilles-peskine-arm
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Oct 16, 2025

Fixes #10458.

I didn't find any other similar cross-submodule relative link in documentation in Mbed TLS or in TF-PSA-Crypto.

PR checklist

  • changelog not required because: doc only
  • development PR here
  • TF-PSA-Crypto PR not required because: no similar problem in crypto
  • framework PR not required
  • 3.6 PR not required because: introduced in 4.0
  • tests not required because: doc only

@gilles-peskine-arm
Fix documentation link to submodule that doesn't work on GitHub
58439de 
Fixes Mbed-TLS#10458

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) labels Oct 16, 2025
ronald-cron-arm
ronald-cron-arm approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpg
mpg approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-project-automation github-project-automation bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Oct 17, 2025
@mpg mpg removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Oct 17, 2025
@mpg mpg added this pull request to the merge queue Oct 17, 2025
@mpg mpg added the approved Design and code approved - may be waiting for CI or backports label Oct 17, 2025
Merged via the queue into Mbed-TLS:development with commit b180696 Oct 17, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Has Approval to Done in Roadmap pull requests (new board) Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpg mpg mpg approved these changes

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

Assignees

No one assigned

Labels

approved Design and code approved - may be waiting for CI or backports size-xs Estimated task size: extra small (a few hours at most)

Projects

Roadmap pull requests (new board)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot find "TF-PSA-Crypto migration guide"

3 participants

@gilles-peskine-arm @mpg @ronald-cron-arm