Iotcrypt 237 hkdf doc #1920
Merged
Iotcrypt 237 hkdf doc #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanesca
added
mbed TLS team
needs-review
bmurray7
reviewed
Aug 6, 2018
include/mbedtls/hkdf.h
Outdated
| * \param prk A pseudorandom key of at least md.size bytes. \p prk is usually, | ||
| * the output from the HKDF extract step. | ||
| * \param prk A pseudorandom key of at least md.size bytes. \p prk is | ||
| * usually, the output from the HKDF extract step. |
There was a problem hiding this comment.
I feel that this comma is not needed in this sentence.
Patater
reviewed
Aug 7, 2018
ChangeLog
Outdated
| @@ -6,6 +6,12 @@ Bugfix | |||
| * Fixes an issue with MBEDTLS_CHACHAPOLY_C which would not compile if | |||
| MBEDTLS_ARC4_C and MBEDTLS_CIPHER_NULL_CIPHER weren't also defined. #1890 | |||
|
|
|||
| Changes | |||
|
|
|||
There was a problem hiding this comment.
We don't usually put a newline after the section title.
Patater
previously approved these changes
Aug 7, 2018
|
CI failure is test_suite_timing on FreeBSD, which is a known issue. |
|
Travis CI failure is odd: filed as #1925 |
|
retest |
moranpeker
previously approved these changes
Aug 14, 2018
The standard HKDF security guarantees only hold if `mbedtls_hkdf()` is used or if `mbedtls_hkdf_extract()` and `mbedtls_hkdf_expand()` are called in succession carefully and an equivalent way. Making `mbedtls_hkdf_extract()` and `mbedtls_hkdf_expand()` static would prevent any misuse, but doing so would require the TLS 1.3 stack to break abstraction and bypass the module API. To reduce the risk of misuse we add warnings to the function descriptions.
yanesca
dismissed stale reviews from moranpeker, dgreen-arm, and Patater
via
08a4aeb
yanesca
force-pushed
the
iotcrypt-237-hkdf-doc
branch
from
d680211 to
08a4aeb
Compare
|
I have rebased the PR, it should be identical to the original. You can find the original branch here: @moranpeker @Patater could you please review it again? |
Patater
approved these changes
Aug 14, 2018
moranpeker
approved these changes
Aug 15, 2018
|
retest |
1 similar comment
|
retest |
Patater
removed
the
needs-review
|
retest |
|
retest |
Patater
added
approved
|
This is labelled as 'Mbed TLS team', and is from Arm, so doesn't need the 'CLA not applicable' label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add warnings to the documentation of the HKDF module to reduce the risk of misusing the mbedtls_hkdf_extract() and mbedtls_hkdf_expand() functions. Fixes #1775.
Status
READY
Requires Backporting
NO
Migrations
NO