Backport 2.1: Add support for alternative CSR headers/footers #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for RFC7468, and the alternative Microsoft footer/headers for CSR's that contain the text 'BEGIN NEW CERTIFICATE REQUEST' instead of 'BEGIN CERTIFICATE REQUEST'.
Add Changelog entry for fix for alternative header/footers in CSR's.
Add a test case for alternative headers possible for CSR's, as defined in RFC7468.
Change the secondary X509 CSR parsing call for the alternative MS header to only occur if the first call fails due to the header being unfound, instead of any call.
RonEld
added
bug
CLA not applicable
needs-review
|
Mbed TLS 2.1 is now End of Life, as has been announced. Unfortunately that means no further releases of Mbed TLS 2.1 will be made, so this PR will not be merged, and is closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of PR #2040.
Adds support for alternative CSR headers, as defined by RFC7468. Microsoft uses alternative footers/headers for CSR's that contain the text 'BEGIN NEW CERTIFICATE REQUEST' instead of 'BEGIN CERTIFICATE REQUEST'. This PR adds support for those CSRs.
This is an enhancement in the sense that it supports more tools, but it's also a fix for an interoperability problem. The fix comes at no cost to the API, so I think it should be backported. I'll do that once this PR is approved.
This PR fixes #767.
Status
READY
Todos