Backport 2.7: Add limits.h inclusion to ssl_tls.c and udp_proxy.c #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
RonEld
added
bug
CLA not applicable
needs-review
RonEld
previously approved these changes
Feb 17, 2019
|
@hanno-arm - please review this backport. |
dgreen-arm
previously approved these changes
Mar 5, 2019
There was a problem hiding this comment.
This is a faithful backport of #1999, but there is a build failure with generate_errors.pl
dgreen-arm
previously requested changes
Mar 5, 2019
There was a problem hiding this comment.
This is a faithful backport of #1999, but there is a build failure with generate_errors.pl
Patater
added
needs-work
needs-ci
|
This is failing CI checks and needs work to fix. |
The standard C library header limits.h was only being included by check_config.h so was being missing if users provided their own config.h that didn't include check_config.h. Signed-off-by: Simon Butcher <simon.butcher@arm.com>
Adds a ChangeLog entry for GitHub issue Mbed-TLS#1803. Signed-off-by: Simon Butcher <simon.butcher@arm.com>
To ensure check_config.h is always included, even if users provide their own config.h file, this adds inclusion of check_config.h to all source files. Signed-off-by: Simon Butcher <simon.butcher@arm.com>
This removes inclusion of the check_config.h header from the config files shipped with Mbed TLS. Inclusion is no longer needed as it's included now in all the source code files. Signed-off-by: Simon Butcher <simon.butcher@arm.com>
simonbutcher
force-pushed
the
missing-limits-header-2.7
branch
from
55a438c
to
546d5b4
Compare
simonbutcher
added
needs-review
|
The 2.7 branch is no longer maintained, so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of PR #1999 to branch
mbedtls-2.7.The standard C library header limits.h was only being included by
check_config.hso was being missing if users provided their own config.h that didn't includecheck_config.h.This fixes #1803.
Status
READY
Todos