Add combo build support #287
Conversation
|
Hi @ghost. Thank you for your contribution! I can see that this PR is the second part of #286 which is renaming some of the symbols in the library that have collisions. However, before looking into the code in detail, could you please let us know what is the motivation behind creating a single source file containing the whole library? |
|
This PR, similar to it's sister PR #286, is asking the project to support a new type of distribution. As stated in #286, if we adopt it, it needs to be properly maintained, to avoid being broken in the future, which is otherwise likely to happen again and again. The changes in this PR are present only in our GNU Makefile not Cmake, and whilst I’m not sure that's the best place to do this and it would be better done in the Cmake file, I think the intent of this PR could easily be maintained outside the library in the distribution, similar to the way other distro's maintain their packages with files outside the library. By rejecting this PR, I don't think we’re stopping anyone from doing this Combo distro. I don't think we want to obstruct using the library in this way, but I don't think this PR is the way we'd like to do it. If anyone out there (including @ghost) still cares and disagrees with this conclusion, please respond and say so! We're open to other views. So, I'm therefore closing this PR. |
* Mbed-TLS#272: Insert doxygen comments on old algorithms so they appear in PSA documentation * Mbed-TLS#285: SE driver: make persistent data work * Mbed-TLS#279: Include IANA reference in the definition of ECC curves and DH groups * Mbed-TLS#287: DRBG documentation improvements * Mbed-TLS#297: Fix int overflow in mbedtls_asn1_get_int (Credit to OSS-Fuzz)
…nist-crypto DRBG documentation improvements
…salt_padding Fix OOB read in key generation for encrypted headers with GCM ciphers.
3 participants
This PR adds a "combo" target to the top level Makefile that builds a combo distribution under "./dist".
The script is scripts/combo.sh.