-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Merge documentation from Mbed Crypto #3094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge documentation from Mbed Crypto #3094
Conversation
Text copied from README.md in Mbed Crypto.
From Mbed Crypto.
Adapted from the section in Mbed Crypto, with the addition of specific compiler versions. Only mention Python 3; Python 2 may still work but it is no longer supported upstream so we will not maintain compatibility anymore.
We missed this when we changed config.pl to config.py.
The Doxygen-generated manual includes PSA interfaces, so we don't need to tell people to read the specification instead. Do link to the specification portal, but from the PSA API section, not from the Mbed TLS documentation section.
mpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AndrzejKurek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comma change requested.
Co-Authored-By: Andrzej Kurek <andrzej.kurek@arm.com>
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This has two approvals (one is not indicated on GitHub because it's shared between @gilles-peskine-arm and @mpg). CI is only failing due to known issues, and is irrelevant anyway because this PR only changes documentation files. This is ok to merge. |
Update
README.mdto mention Mbed Crypto and the PSA crypto API.This is a companion to #3085 which should be merged soon afterwards. I made it a separate pull request to reduce the review volume, group the commits in the history, and separate the CI feedback cycles.