Skip to content

Conversation

@gilles-peskine-arm
Copy link
Contributor

Update README.md to mention Mbed Crypto and the PSA crypto API.

This is a companion to #3085 which should be merged soon afterwards. I made it a separate pull request to reduce the review volume, group the commits in the history, and separate the CI feedback cycles.

Text copied from README.md in Mbed Crypto.
Adapted from the section in Mbed Crypto, with the addition of specific
compiler versions. Only mention Python 3; Python 2 may still work but
it is no longer supported upstream so we will not maintain
compatibility anymore.
We missed this when we changed config.pl to config.py.
The Doxygen-generated manual includes PSA interfaces, so we don't need
to tell people to read the specification instead. Do link to the
specification portal, but from the PSA API section, not from the Mbed
TLS documentation section.
@gilles-peskine-arm gilles-peskine-arm added mbed TLS team needs-review Every commit must be reviewed by at least two team members, needs-preceding-pr Requires another PR to be merged first labels Mar 9, 2020
@mpg mpg self-requested a review March 11, 2020 08:44
mpg
mpg previously approved these changes Mar 13, 2020
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AndrzejKurek AndrzejKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comma change requested.

@mpg mpg added needs-work and removed needs-review Every commit must be reviewed by at least two team members, labels Mar 19, 2020
Co-Authored-By: Andrzej Kurek <andrzej.kurek@arm.com>
@mpg mpg added needs-review Every commit must be reviewed by at least two team members, good-first-issue Good for newcomers and removed needs-work labels Mar 19, 2020
@mpg mpg requested a review from AndrzejKurek March 19, 2020 11:37
@mpg mpg self-assigned this Mar 19, 2020
@gilles-peskine-arm gilles-peskine-arm removed needs-preceding-pr Requires another PR to be merged first needs-review Every commit must be reviewed by at least two team members, labels Mar 24, 2020
Copy link
Contributor Author

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hereby approve the change made by @mpg since 260b31d which I made and he approved.

@gilles-peskine-arm
Copy link
Contributor Author

This has two approvals (one is not indicated on GitHub because it's shared between @gilles-peskine-arm and @mpg). CI is only failing due to known issues, and is irrelevant anyway because this PR only changes documentation files. This is ok to merge.

@gilles-peskine-arm gilles-peskine-arm merged commit 7a054d1 into Mbed-TLS:development Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good-first-issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants