Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA: Rename AEAD tag length macros #3967

Merged
merged 1 commit into from
Feb 12, 2021
Merged

PSA: Rename AEAD tag length macros #3967

merged 1 commit into from
Feb 12, 2021

Conversation

bensze01
Copy link
Contributor

@bensze01 bensze01 commented Dec 16, 2020 •
edited
Loading

This PR renames the AEAD tag length macros that were renamed in the PSA crypto API spec between Beta 3 and 1.0.0

Fixes parts of #3278

Status

READY

Requires Backporting

No, PSA only

Migrations

Yes, This brings them in line with PSA Crypto API 1.0.0

PSA_ALG_AEAD_WITH_DEFAULT_TAG_LENGTH -> PSA_ALG_AEAD_WITH_DEFAULT_LENGTH_TAG
PSA_ALG_AEAD_WITH_TAG_LENGTH -> PSA_ALG_AEAD_WITH_SHORTENED_TAG

@bensze01 bensze01 added enhancement mbed TLS team needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Dec 16, 2020
@bensze01 bensze01 force-pushed the psa_macro_rename branch 2 times, most recently from 7d0ad5e to de9e9ac Compare December 16, 2020 13:58
@bensze01 bensze01 self-assigned this Dec 16, 2020
@bensze01 bensze01 mentioned this pull request Jan 11, 2021
Merged
@bensze01 bensze01 added needs-preceding-pr Requires another PR to be merged first needs-work and removed needs-ci Needs to pass CI tests needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 18, 2021
@bensze01
Copy link
Contributor Author

bensze01 commented Jan 18, 2021 •
edited
Loading

#3984 Is dealing with an overlapping set of macros. Once the relevant parts of this PR are merged into that one (which I've already requested), I'll drop the overlapping changes, and refocus this PR on renaming
PSA_ALG_AEAD_WITH_DEFAULT_TAG_LENGTH -> PSA_ALG_AEAD_WITH_DEFAULT_LENGTH_TAG and
PSA_ALG_AEAD_WITH_TAG_LENGTH -> PSA_ALG_AEAD_WITH_SHORTENED_TAG
which would have been out of scope in the first place.

@bensze01 bensze01 changed the title PSA: Rename output buffer size macros PSA: Rename AEAD tag length macros Jan 20, 2021
@bensze01 bensze01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review needs-ci Needs to pass CI tests and removed DO-NOT-MERGE needs-preceding-pr Requires another PR to be merged first needs-work labels Jan 20, 2021
@bensze01
Copy link
Contributor Author

bensze01 commented Jan 20, 2021 •
edited
Loading

I've pushed a new version of the PR that removes the overlaps with #3984, and renamed the PR accordingly.

@bensze01 bensze01 added component-crypto Crypto primitives and low-level interfaces PSA compliance and removed needs-ci Needs to pass CI tests labels Jan 20, 2021
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jan 27, 2021
Merged
3 tasks
@bensze01
Copy link
Contributor Author

bensze01 commented Feb 8, 2021

I've rebased this PR on top of develoment.

ronald-cron-arm
ronald-cron-arm requested changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one remaining usage of the PSA_ALG_AEAD_WITH_TAG_LENGTH in tests/scripts/set_psa_test_dependencies.py that was introduced by PR 4012. Otherwise this looks good to me.

@bensze01 bensze01 removed the request for review from ronald-cron-arm February 11, 2021 09:34
@bensze01
Rename AEAD tag length macros
a63b20d 
This brings them in line with PSA Crypto API 1.0.0

PSA_ALG_AEAD_WITH_DEFAULT_TAG_LENGTH -> PSA_ALG_AEAD_WITH_DEFAULT_LENGTH_TAG
PSA_ALG_AEAD_WITH_TAG_LENGTH         -> PSA_ALG_AEAD_WITH_SHORTENED_TAG

Signed-off-by: Bence Szépkúti <bence.szepkuti@arm.com>
@bensze01 bensze01 added needs-ci Needs to pass CI tests and removed needs-work labels Feb 11, 2021
@bensze01
Copy link
Contributor Author

Rebased PR again, and updated to account for new occurrences of PSA_ALG_AEAD_WITH_TAG_LENGTH added in #4010 and #4012

@gabor-mezei-arm gabor-mezei-arm self-requested a review February 11, 2021 12:40
@bensze01 bensze01 removed the needs-ci Needs to pass CI tests label Feb 11, 2021
ronald-cron-arm
ronald-cron-arm approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm ronald-cron-arm merged commit 7339335 into Mbed-TLS:development Feb 12, 2021
@bensze01 bensze01 removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm ronald-cron-arm approved these changes

@gabor-mezei-arm gabor-mezei-arm gabor-mezei-arm approved these changes

Assignees

@bensze01 bensze01

Labels
component-crypto Crypto primitives and low-level interfaces enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bensze01 @ronald-cron-arm @gabor-mezei-arm