Stop CMake out of source tests running on 16.04 #5233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the out of source CMake test on Ubuntu 16.04 using more than one processor (as the CI does) can create a race condition whereby the build fails to see a generated file, despite that file actually having been generated. This problem appears to go away with 18.04 or newer, so make the out of source tests not supported on Ubuntu 16.04 Signed-off-by: Paul Elliott <paul.elliott@arm.com>
paul-elliott-arm
added
bug
component-test
paul-elliott-arm
added
needs-backports
daverodgman
removed
the
needs-reviewer
daverodgman
reviewed
Nov 26, 2021
| @@ -2676,6 +2676,36 @@ component_test_valgrind () { | |||
| fi | |||
| } | |||
|
|
|||
| support_test_cmake_out_of_source () { | |||
There was a problem hiding this comment.
This seems not to be called anywhere?
There was a problem hiding this comment.
The code in all.sh automatically calls support_$name if it exists when deciding whether to call component_$name.
| @@ -0,0 +1,4 @@ | |||
| Bugfix | |||
There was a problem hiding this comment.
Not sure a changelog entry is warranted for a CI fix
|
The point of this patch was to fix CI on #5155 so it's been included into that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running the out of source CMake test on Ubuntu 16.04 using more than one processor (as the CI does) can create a race condition whereby the build fails to see a generated file, despite that file actually having been generated. This problem appears to go away with 18.04 or newer, so make the out of source tests not supported on Ubuntu 16.04
This is our mitigation for #5223 - Given 16.04 is already out of support, it seemed the simplest option rather than trying to chase down the race condition.
Status
READY
Requires Backporting
NO
Migrations
NO
Todos
Steps to test or reproduce
CMake out of source tests should run clean on CI 100%