Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbedtls_ecp_point_read_binary from compressed fmt #6282
mbedtls_ecp_point_read_binary from compressed fmt #6282
Changes from all commits
2ff7711
369bfb9
cbfd5e9
fcabc28
4524161
8b6d14b
efde9d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we could have avoided the need to change test data by returning
MBEDTLS_ERR_ECP_FEATURE_UNAVAILABLE
here, but that would have been less correct, so I think you did the right thing here.However, if we consider this for backporting in 2.28, then we might consider making
FEATURE_UNAVAILABLE
in 2.28 (not here) in order to improve backwards compatibility (ie we wouldn't need to update existing test cases in 2.28).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of
MPI_ECP_*
macros means that a backport to 2.28 will have to omit those later commits.