Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChangeLog entry for DTLS Connection ID #6681

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Add ChangeLog entry for DTLS Connection ID #6681

merged 1 commit into from
Nov 29, 2022

Conversation

mpg
Copy link
Contributor

@mpg mpg commented Nov 29, 2022

We managed to forget it in #6264

@mpg mpg added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Nov 29, 2022
@mpg mpg self-assigned this Nov 29, 2022
@mpg mpg mentioned this pull request Nov 29, 2022
Merged
4 tasks
@AndrzejKurek AndrzejKurek self-requested a review November 29, 2022 08:48
yanesca
yanesca previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AndrzejKurek
AndrzejKurek suggested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@AndrzejKurek AndrzejKurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change requested.

@mpg mpg force-pushed the changelog-6264 branch 2 times, most recently from 1195ebe to 02924a4 Compare November 29, 2022 08:59
AndrzejKurek
AndrzejKurek previously approved these changes Nov 29, 2022
View reviewed changes
tom-cosgrove-arm
tom-cosgrove-arm reviewed Nov 29, 2022
View reviewed changes
ChangeLog.d/dtls-connection-id.txt Outdated
won't be able to communicate with peers that use the standard (non-draft)
version. If you need to interoperate with both classes of peers with the
same build of Mbed TLS, please let us know about your situation on the
mailing list or github.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proper noun

Suggested change
mailing list or github.
mailing list or GitHub.

@mpg
Add ChangeLog entry for DTLS Connection ID
37d41c7 
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
@mpg mpg removed the needs-reviewer This PR needs someone to pick it up for review label Nov 29, 2022
yanesca
yanesca approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mpg mpg removed the request for review from tom-cosgrove-arm November 29, 2022 10:10
@mpg mpg added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, labels Nov 29, 2022
@mpg
Copy link
Contributor Author

mpg commented Nov 29, 2022

This PR only touches ChangeLog.d, and it passes Travis which includes tests/scripts/all.sh -k 'check_*' which are the only parts that care about files in this directory (check_files and check_changelog specifically), so we don't need to wait for the rest of the CI to complete before merging.

@mpg mpg removed the needs-ci Needs to pass CI tests label Nov 29, 2022
@mpg mpg merged commit 7f5bc5c into Mbed-TLS:development Nov 29, 2022
@daverodgman daverodgman mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm left review comments

@yanesca yanesca yanesca approved these changes

@AndrzejKurek AndrzejKurek AndrzejKurek approved these changes

Assignees

@mpg mpg

Labels
approved Design and code approved - may be waiting for CI or backports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpg @yanesca @AndrzejKurek @tom-cosgrove-arm