Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Fix the problem of printing "Terminated" in compat.sh under Ubuntu-22.04 #6954

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Backport 2.28: Fix the problem of printing "Terminated" in compat.sh under Ubuntu-22.04 #6954

merged 2 commits into from
Jan 26, 2023

Conversation

gilles-peskine-arm
Copy link
Contributor

Trivial backport of #6917

Gatekeeper checklist

Yanray Wang added 2 commits January 20, 2023 15:51
@gilles-peskine-arm
Remove Terminated message from stdout
d2ad200 
Under Ubuntu-22.04, wait command prints out Terminated message
if the process has been killed by kill command. This messes up
the output in compat.sh

Signed-off-by: Yanray Wang <yanray.wang@arm.com>
@gilles-peskine-arm
Redirect stdout/stderr to SRV_OUT
2a7b2a6 
Under Ubuntu-22.04, wait command prints out Terminated message.
Therefore server process is handled with identical ways like other
processes in compat.sh. In addition, PROCESS_ID is renamed as
SRV_PID to improve code readability.

Signed-off-by: Yanray Wang <yanray.wang@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) component-test Test framework and CI scripts priority-high High priority - will be reviewed soon labels Jan 20, 2023
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jan 20, 2023
Merged
3 tasks
davidhorstmann-arm
davidhorstmann-arm approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a trivial backport.

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports single-reviewer This PR qualifies for having only one reviewer and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 26, 2023
@gilles-peskine-arm gilles-peskine-arm merged commit c2738f2 into Mbed-TLS:mbedtls-2.28 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-test Test framework and CI scripts priority-high High priority - will be reviewed soon single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilles-peskine-arm @davidhorstmann-arm