Reject duplicated build steps in the outcome file #9286
+190
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-work
needs-ci
This was referenced Jun 19, 2024
|
Note "Reject duplicated build steps in the outcome file" seems very different from "use .s for assembly files" - presumably the latter could be a separate PR, making everything easier to review? |
|
@tom-cosgrove-arm You're right, this turned into “fix issues in all.sh”, mostly so that I could have distinct configuration names. I'll break that unexpected part out. |
4 tasks
gilles-peskine-arm
added
the
needs-preceding-pr
|
I've split out the |
gilles-peskine-arm
force-pushed
the
outcome-check-repeated-configurations
branch
2 times, most recently
from
1073dd7 to
5c04140
Compare
5 tasks
5 tasks
gilles-peskine-arm
force-pushed
the
outcome-check-repeated-configurations
branch
from
5c04140 to
13d5b99
Compare
We no longer have two (only partially distinct) implementations of ECJ-PAKE cipher suites in TLS, now that the non-MBEDTLS_USE_PSA_CRYPTO implementation is being removed. We may want to add this testing back in the future, but we'll have to use an old Mbed TLS instead of a differently-built one. Mbed-TLS#9740 Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
added
size-s
gilles-peskine-arm
force-pushed
the
outcome-check-repeated-configurations
branch
from
13d5b99 to
ce25947
Compare
Add an outcome line when all.sh calls make. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
… builds Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Some versions on CMake (on some platforms?) run make (not $(MAKE)) under the hood on targets named cmTC_* (CMake TryCompile). Ignore those calls. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This should make failures.csv on the CI be a complete list of failures (although it will still have incomplete information on what has failed, if what failed wasn't tracked individually). Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
component_test_tfm_config_no_p256m was not building sample programs, but component_test_tfm_config_p256m_driver_accel_ec was. This is now flagged as a discrepancy by outcome analysis. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This comes up in `psa_collect_statuses.py` and possibly (I didn't finish the analysis) some CMake builds, which were reporting duplicate `make` steps. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
As a debugging help, log the `make` command line in the outcome file. This is not accurate if a command line argument contains some special characters, but good enough to help debugging. Hopefully this will only be temporary. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
gilles-peskine-arm
force-pushed
the
outcome-check-repeated-configurations
branch
from
ce25947 to
b3940ab
Compare
When emitting a line for the outcome file for `make`, indicate if the target is being built in a different directory or with a different makefile. We don't currently do this explicitly with an ambiguous target name, but it happens under the hood with older versions of CMake (observed with CMake 3.10.2, not with CMake 3.22.1). Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9023
Status: work in progress, I want CI feedback
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")