Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 3.6: Add pragma for bcrypt.lib - Fix win build with cmake #9554

Open
wants to merge 5 commits into
base: mbedtls-3.6
Choose a base branch
from
Open

Backport 3.6: Add pragma for bcrypt.lib - Fix win build with cmake #9554

wants to merge 5 commits into from

Conversation

tobil4sk
Copy link

Description

Backport of #9055 for mbedtls 3.6

PR checklist

Kal42 and others added 2 commits September 10, 2024 13:55
@Kal42 @tobil4sk
Add pragma for bcrypt.lib
7f85eb6 
Needed when build with cmake

Signed-off-by: Kal42 <Kal42@users.noreply.github.com>
Signed-off-by: Tobiasz Laskowski <tobil4sk@outlook.com>
@tobil4sk
Update changelog
da21d25 
Signed-off-by: Tobiasz Laskowski <tobil4sk@outlook.com>
@gilles-peskine-arm gilles-peskine-arm added needs-work needs-review Every commit must be reviewed by at least two team members, component-platform Portability layer and build scripts needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Sep 10, 2024
@tobil4sk
Add missing changelog entry file extension
eb47d86 
Signed-off-by: Tobiasz Laskowski <tobil4sk@outlook.com>
@tobil4sk
Fix changelog entry
8237dcc 
Signed-off-by: Tobiasz Laskowski <tobil4sk@outlook.com>
@tobil4sk
Fix changelog entry line length
d34546d 
Signed-off-by: Tobiasz Laskowski <tobil4sk@outlook.com>
@tom-cosgrove-arm
Copy link
Contributor

Since this is a backport, shouldn't the development PR #9055 also have a changelog entry?

@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Sep 18, 2024
Open
4 tasks
@tom-cosgrove-arm
Copy link
Contributor

No point reviewing this until development PR is rebased and ChangeLog added

@tom-cosgrove-arm tom-cosgrove-arm removed needs-work needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
component-platform Portability layer and build scripts priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobil4sk @tom-cosgrove-arm @gilles-peskine-arm @Kal42