Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA Crypto Configuration Split #9567

Open
wants to merge 27 commits into
base: development
Choose a base branch
from
Open

PSA Crypto Configuration Split #9567

wants to merge 27 commits into from

Conversation

minosgalanakis
Copy link
Contributor

Description

Draft PR, for testing purposes

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog provided | not required because:
  • development PR provided # | not required because:
  • framework PR provided Mbed-TLS/mbedtls-framework# | not required
  • 3.6 PR provided # | not required because:
  • 2.28 PR provided # | not required because:
  • tests provided | not required because:

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@minosgalanakis minosgalanakis added component-crypto Crypto primitives and low-level interfaces size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon needs-work needs-ci Needs to pass CI tests labels Sep 16, 2024
@minosgalanakis minosgalanakis force-pushed the config_split branch 6 times, most recently from de354f3 to 0ff3245 Compare September 23, 2024 13:58
@ronald-cron-arm ronald-cron-arm removed the priority-high High priority - will be reviewed soon label Sep 25, 2024
@minosgalanakis minosgalanakis force-pushed the config_split branch 4 times, most recently from 68a8594 to 1074738 Compare September 26, 2024 17:30
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Oct 2, 2024
Open
@minosgalanakis minosgalanakis mentioned this pull request Oct 2, 2024
Merged
5 tasks
@minosgalanakis minosgalanakis force-pushed the config_split branch 9 times, most recently from 6ac280e to 20f4598 Compare October 10, 2024 11:41
@minosgalanakis minosgalanakis force-pushed the config_split branch 2 times, most recently from f96ae61 to f2aec87 Compare October 21, 2024 10:20
@minosgalanakis
crypto_config: Moved Platform options.
c653de4 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
components-build-system: Added support for psa_crypto custom configur…
7f77307 
…ation file.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
crypto_config: Moved General and test configuration options.
b8fa3fb 
Only move the boolean configuration options.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
crypto_config: Moved cryptographic mechanism selection options.
ffc642f 
Only move the boolean configuration options.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
test-suites: Replaced NIST_KW_C with SSL_ALL_ALERT_MESSAGES
11962fb 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
crypto_config: Moved data format selection options.
93858ce 
Only move the boolean configuration options.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
crypto_config: Moved PSA core selection options.
f8588d3 
Only move the boolean configuration options.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
crypto_config: Moved crypto drivers selection options.
22b0505 
Only move the boolean configuration options.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
crypto_config: Moved legacy-crypto selection options.
727211a 
Only move the boolean configuration options.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
Updated test-configs.
9e2c2ac 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
configs/migrated config-symmetric-only
0ac269a 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
config-symmetric-only: Enabled MBEDTLS_PSA_CRYPTO_CONFIG
b87d35c 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
workaround: Adjusted check feature test to test for MBEDTLS_TIMING_C.
a72fe0c 
Features are generated by scripts/generate_features.pl which needs to
be updated for the repo-split work.

Picking another feature still meets the original test's requirements.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
configs: Migrated config-ccm-psk-(d)tls1_2
83f74f7 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
configs: Migrated config-suite-b
b23e13d 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
configs: Migrated config-tfm
fad4850 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
configs: Migrated config-thread
c72bacd 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
test-suites: Minor Fixes
189eb01 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
crypto_config: Temporary set MBEDTLS_PSA_CRYPTO_CONFIG
511683d 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
config.py: Disabled default entry for crypto_config
7035bcb 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
test_memsan_constant_flow_psa: Set to not re-generate files.
d834851 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
libtestdriver: Added minimal configuration for tf-psa-crypto config.
7759142 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
libtestdriver test config: Migrated configuration.
81336f4 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
tests/configs: Adjusted for migration of MBEDTLS_PSA_CRYPTO_CONFIG_FILE.
efdf33f 
Moving forward the MBEDTLS_PSA_CRYPTO_CONFIG_FILE now resides in the
ts-psa/crypto configuration. This patch removes it from the library
configuration files, and updates the tests to explicitely use it.

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
Workaround: Adjusted build_cmake_custom_config_file to use absolute p…
99dc32c 
…aths

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
@minosgalanakis
Test commit: will remove
88909d2 
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronald-cron-arm ronald-cron-arm ronald-cron-arm left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests needs-work priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Mbed TLS Epics
Status: Configuration split
Roadmap pull requests (new board)
Status: In Development
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minosgalanakis @ronald-cron-arm @gilles-peskine-arm