Remove obsolete CI Scripts #9666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Ramsey
added
enhancement
priority-high
|
For this pull request to be merged, pull request: 178 in mbedtls-test must first be merged. Since config.pl is being removed, Windows testing will fail until the test CI uses config.py. |
Harry-Ramsey
added
needs-ci
This commit removes Docker CI scripts from the repository as they are no longer necessary with CI images being publically available. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit removes obsolete Travis CI scripts that are no longer required due to the transition to a publically available CI image. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit removes the obsolte config.pl file which was used to transition to config.py. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit removes tcp_client.pl and removes it from ssl-opt.sh as it has been replaced by test_suite_ssl. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
This commit refactors scripts to use config.py which replaces config.pl. Signed-off-by: Harry Ramsey <harry.ramsey@arm.com>
Harry-Ramsey
force-pushed
the
remove-obsolete-ci-scripts-development
branch
from
51fb1af to
fe81cfe
Compare
mpg
added
needs-review
3 tasks
gilles-peskine-arm
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
LGTM.
But I think we should backport the removal of Dockerfile and the related scripts. The dockerfile here is obsolete, and it occasionally confuses external contributors. We've long wanted to remove it (#5427 — that issue asked to adapt the *-in-docker.sh scripts to use the Docker images from mbedtls-test, but I agree with removing the scripts).
gilles-peskine-arm
added
approved
5 tasks
mpg
removed
the
needs-backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes scripts from the repository as they are no longer necessary with CI images being publically available.
This pull request closes: #9663 and closes: #5427.
PR checklist
Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.
Help make review efficient: